Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]Fix end of the week when the date provider is the end of the week #66

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

rntdrts
Copy link
Contributor

@rntdrts rntdrts commented Feb 13, 2021

When the date provided is the end of the week we should return that same date, with the end of the week format.

This should fix this 👉 #61

@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #66 (ce063dd) into master (3a86b77) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   89.08%   89.11%   +0.03%     
==========================================
  Files           3        3              
  Lines         632      634       +2     
==========================================
+ Hits          563      565       +2     
  Misses         44       44              
  Partials       25       25              
Impacted Files Coverage Δ
carbon.go 90.46% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71fce27...77df8a4. Read the comment docs.

@tlfbrito tlfbrito merged commit 21aebc7 into master Feb 13, 2021
@rntdrts rntdrts deleted the fix-end-of-the-week branch April 16, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants