Add Zabbix API timeout #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configurable timeouts for connecting and reading from the Zabbix API. This prevents the application from hanging from waiting indefinitely on HTTP requests that will never be answered by the API.
Config
A new config option has been added to the
[zabbix]table:By default, the timeout is set to 60 seconds, but can be disabled by setting it to 0:
Dependencies
A new dev dependency
pytest-timeouthas been added to facilitate testing of subprocesses. Its fixturepytest.mark.timeoutsimplifies termination of processes with no set end duration. It allows us to easily wait for certain conditions in the processes without fear of looping forever if the condition is not hit.