Refactoring user model and associated permission interface #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pederhan
reviewed
Nov 26, 2024
ponas
reviewed
Nov 26, 2024
- Rename `is_mreg_group_admin` to `is_mreg_hostgroup_admin` as its much more precise. We should consider renaming the JSON output as well but that would require modifying the CLI. - Restrict whois to supers, admins, and hostgroup admins. Network admins shouln't have to manage user access checking. - Add documenation to the User model. - Also fixed the settings tests with excellent help from @ponas. Thanks!
terjekv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate user-related permissions to the User model, instead of using functions in permissions.py that take user objects or requests as parameters. This is a building block towards cleaning up the permissions interface in general, attempting to make it more readable and extendable.