Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with UserInfo crashing on permissions. #565

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

terjekv
Copy link
Collaborator

@terjekv terjekv commented Nov 25, 2024

  • JSON-ifying network addresses caused an exception. Casting it to str works.
  • Also fixes permission logic for the UserInfo endpoint.
  • Added testing of said endpoint with permissions.

  - JSON-ifying network addresses caused an exception. Casting it to str works.
 - Also fixes permission logic for the UserInfo endpoint.
 - Added testing of said endpoint with permissions.
@terjekv terjekv self-assigned this Nov 25, 2024
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 98.372% (+0.004%) from 98.368%
when pulling 98a4849 on fix_500_errors_for_userinfo
into af6611e on master.

Copy link
Member

@pederhan pederhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terjekv terjekv merged commit 2e0a77d into master Nov 25, 2024
29 checks passed
@pederhan pederhan deleted the fix_500_errors_for_userinfo branch November 25, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants