Meta endpoint expansion #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `meta/versions` is now gone, replaced with `meta/version` (server version) and `meta/libraries` (some core libraries).
terjekv
force-pushed
the
meta_endpoint_expansion
branch
from
e25383d to
dbd51e3
Compare
This endpoint shows some meta information about the user in question. Normal users can see their own information, superusers, admins, group admins, and network admins can add `?username=foo` to see information about that user. Information provided: - username - django status for the user (superuser, admin, active) - mreg status for the user (superuser, admin, group admin, network admin, hostpolicy admin, dns wildcard admin, and underscore admin). - group memberships - mreg permissions granted based on the groups one is a member of.
|
We are getting dangerously close to the point where the But yeah, we either need to consider setting the limit to 97, or the tests should be expanded to cover more of the changes in this PR. |
|
This could do with some testing indeed. I'll poke at it. |
|
Tests added, coverage OK. I'll do another coverage pass PR soon[tm]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
api/meta/versionsis now gone! (But this was never taken into use)This has been replaced with
api/meta/version(server version, open to authenticated users) andapi/meta/libraries(core libraries, available to superusers and administrators).