-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uv for dependency management and versioning #553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terjekv
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
pederhan
commented
Nov 13, 2024
pederhan
commented
Nov 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds dependency management backed by a uv lockfile. Building, installing and running the project has been fully migrated to uv in CI as well.
Development dependencies
Development dependencies are now specified as PEP 735 dependency groups. Dependency groups are not yet supported by pip, so for now, this means the development environment can only be installed with uv. Mreg itself does not require uv.
Docker image
Since uv does not support the
pip wheel
interface, we still have to install pip in the build stage of the dockerfile to build wheels for all of the project's dependencies. This complicates the build stage somewhat.Versioning
The project is now versioned with
setuptools-scm
, which uses git tags to determine the project version. This necessitates git being installed wherever the project is built (such as in the build stage of the dockerfile).The project's version can be accessed via
mreg_cli.__about__.__version__
(or the short-hand importmreg_cli.__version__
).Why not use
uv python install
in the Dockerfile?https://docs.astral.sh/uv/guides/integration/docker/#installing-python-in-musl-based-images