fix: simplify Omit

unional · Mar 24, 2024 · 7227250 · 7227250
1 parent 42d2764
commit 7227250
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/.changeset/itchy-mails-sleep.md b/.changeset/itchy-mails-sleep.md
@@ -0,0 +1,5 @@
+---
+"type-plus": patch
+---
+
+Simplify `Omit` type as the simpler code is working with typescript 5.4
diff --git a/packages/type-plus/src/object/omit.spec.ts b/packages/type-plus/src/object/omit.spec.ts
@@ -65,12 +65,18 @@ describe('Omit<T, K>', () => {
 		expect(x.foo).toBe('bar')
 	})
 
+
 	test('intersection types with generic', () => {
 		type Foo = { a: string, b: string }
-		function foo<T>(input: Omit<Foo & T, 'a'>): void {
-			assertType.isString(input.b)
+		function foo<T>(input: Omit<Foo & T, 'b'>): void {
+			input.a = '1'
+			// @ts-expect-error Property 'b' does not exist
+			input.b = '1'
+
+			// @ts-expect-error	Property 'c' does not exist.
+			input.c = '1'
 		}
-		foo({ b: '1' })
+		foo({ a: '1' })
 	})
 })
 

diff --git a/packages/type-plus/src/object/omit.ts b/packages/type-plus/src/object/omit.ts
@@ -7,11 +7,9 @@ import { reduceByKey } from './reduceKey.js'
 // by Titian Cernicova-Dragomir
 // https://github.com/microsoft/TypeScript/issues/28339#issuecomment-463577347
 // type-zoo
-export type Omit<T, K extends UnionKeys<T>> = T extends T
-	? (keyof T extends K
-		? {}
-		: Pick<T, Exclude<keyof T, K>>)
-	: never
+export type Omit<T, K extends UnionKeys<T>> = T extends unknown
+? Pick<T, Exclude<keyof T, K>>
+: never
 
 /**
  * @deprecated replaced by `Omit`