Add options.ignoreUnconfigured
#64
Conversation
wooorm
added
🦋 type/enhancement
This comment has been minimized.
This comment has been minimized.
When turning this option on, files will only be used if they have an associated detected configuration file. Other files will be ignored. Given that configuration actually happens much later than finding files, how it works is more similar to how a fatal error or so prevents a file from being processed, instead of actual files being ignored. Related-to: unifiedjs/unified-language-server#30.
wooorm
force-pushed
the
ignore-unconfigured
branch
from
ea98e73
to
1bb8496
Compare
| done | ||
| ) | ||
|
|
||
| function done(error) { |
There was a problem hiding this comment.
nit: The following might give a better id of what’s available in the callback:
| function done(error) { | |
| function done(error, code, context) { |
There was a problem hiding this comment.
They’re unused. The code style strips those away. None of the others do this either. So definitely 👎 for doing it in this case in this PR, but open to discussing changing it (here, everywhere?), although I’m personally 👎
There was a problem hiding this comment.
It was just a suggestion. I have no strong feelings on this.
| // If there was no explicit corresponding config file found | ||
| if (!configuration.filePath && context.settings.ignoreUnconfigured) { | ||
| debug('Ignoring file w/o corresponding config file') | ||
| file.data.unifiedEngineIgnored = true |
There was a problem hiding this comment.
Oh cool! So this property is available now after processing too. We don’t need it in unified-language-server now, but it might come in handy some day. Should it be documented?
There was a problem hiding this comment.
It is more a new, another way, to ignore files.
Each step that handles a file now does nothing when this field is set.
I am not particularly fond of documenting it, and neither are the two other existing namespaced fields, because they’re not really meant to be “used” by folks, although documenting them might at least help serve folks that google them because they’re on their files for some reason.
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
Initial checklist
Description of changes
When turning this option on, files will only be used if they have an
associated detected configuration file.
Other files will be ignored.
Given that configuration actually happens much later than finding files,
how it works is more similar to how a fatal error or so prevents a file
from being processed, instead of actual files being ignored.
/cc @remcohaszing