Remove redundant h2 pt.1 (#1)

* Remove `h2` from cart * Remove `h2` from country label * Remove `h2` from `sort_by_label` * Remove more `h2`s
unicomultiplo · Sep 20, 2024 · c98a6d8 · c98a6d8
1 parent 6710336
commit c98a6d8
Show file tree

Hide file tree

Showing 10 changed files with 28 additions and 28 deletions.
diff --git a/sections/announcement-bar.liquid b/sections/announcement-bar.liquid
@@ -143,7 +143,7 @@
         <localization-form class="small-hide medium-hide">
           {%- form 'localization', id: 'AnnouncementCountryForm', class: 'localization-form' -%}
             <div>
-              <h2 class="visually-hidden" id="AnnouncementCountryLabel">{{ 'localization.country_label' | t }}</h2>
+              <span class="visually-hidden" id="AnnouncementCountryLabel">{{ 'localization.country_label' | t }}</span>
               {%- render 'country-localization', localPosition: 'AnnouncementCountry' -%}
             </div>
           {%- endform -%}
@@ -154,7 +154,7 @@
         <localization-form class="small-hide medium-hide">
           {%- form 'localization', id: 'AnnouncementLanguageForm', class: 'localization-form' -%}
             <div>
-              <h2 class="visually-hidden" id="AnnouncementLanguageLabel">{{ 'localization.language_label' | t }}</h2>
+              <span class="visually-hidden" id="AnnouncementLanguageLabel">{{ 'localization.language_label' | t }}</span>
               {%- render 'language-localization', localPosition: 'AnnouncementLanguage' -%}
             </div>
           {%- endform -%}

diff --git a/sections/footer.liquid b/sections/footer.liquid
@@ -262,7 +262,7 @@
           <localization-form>
             {%- form 'localization', id: 'FooterCountryForm', class: 'localization-form' -%}
               <div>
-                <h2 class="caption-large text-body" id="FooterCountryLabel">{{ 'localization.country_label' | t }}</h2>
+                <span class="caption-large text-body" id="FooterCountryLabel">{{ 'localization.country_label' | t }}</span>
                 {%- render 'country-localization', localPosition: 'FooterCountry' -%}
               </div>
             {%- endform -%}

diff --git a/sections/header.liquid b/sections/header.liquid
@@ -206,7 +206,7 @@
           <localization-form class="small-hide medium-hide" data-prevent-hide>
             {%- form 'localization', id: 'HeaderCountryForm', class: 'localization-form' -%}
               <div>
-                <h2 class="visually-hidden" id="HeaderCountryLabel">{{ 'localization.country_label' | t }}</h2>
+                <span class="visually-hidden" id="HeaderCountryLabel">{{ 'localization.country_label' | t }}</span>
                 {%- render 'country-localization', localPosition: 'HeaderCountry' -%}
               </div>
             {%- endform -%}

diff --git a/sections/main-cart-footer.liquid b/sections/main-cart-footer.liquid
@@ -59,7 +59,7 @@
                 </div>
 
                 <div class="totals">
-                  <h2 class="totals__total">{{ 'sections.cart.estimated_total' | t }}</h2>
+                  <span class="totals__total">{{ 'sections.cart.estimated_total' | t }}</span>
                   <p class="totals__total-value">{{ cart.total_price | money_with_currency }}</p>
                 </div>
 

diff --git a/sections/main-collection-product-grid.liquid b/sections/main-collection-product-grid.liquid
@@ -44,9 +44,9 @@
         <form class="facets-vertical-form" id="FacetSortForm">
           <div class="facet-filters sorting caption">
             <div class="facet-filters__field">
-              <h2 class="facet-filters__label caption-large text-body">
+              <span class="facet-filters__label caption-large text-body">
                 <label for="SortBy">{{ 'products.facets.sort_by_label' | t }}</label>
-              </h2>
+              </span>
               <div class="select">
                 {%- assign sort_by = collection.sort_by | default: collection.default_sort_by -%}
                 <select

diff --git a/sections/main-search.liquid b/sections/main-search.liquid
@@ -154,9 +154,9 @@
           <form class="facets-vertical-form" id="FacetSortForm">
             <div class="facet-filters sorting caption">
               <div class="facet-filters__field">
-                <h2 class="facet-filters__label caption-large text-body">
+                <span class="facet-filters__label caption-large text-body">
                   <label for="SortBy">{{ 'products.facets.sort_by_label' | t }}</label>
-                </h2>
+                </span>
                 <div class="select">
                   {%- assign sort_by = search.sort_by | default: search.default_sort_by -%}
                   <select

diff --git a/sections/predictive-search.liquid b/sections/predictive-search.liquid
@@ -117,12 +117,12 @@
       <div class="predictive-search__result-group">
         {%- if predictive_search.resources.products.size > 0 -%}
           <div>
-            <h2
+            <span
               id="predictive-search-products"
               class="predictive-search__heading text-body caption-with-letter-spacing"
             >
               {{- 'templates.search.products' | t -}}
-            </h2>
+            </span>
             <ul
               id="predictive-search-results-products-list"
               class="predictive-search__results-list list-unstyled"

diff --git a/snippets/cart-drawer.liquid b/snippets/cart-drawer.liquid
@@ -31,7 +31,7 @@
         <div class="drawer__inner-empty">
           <div class="cart-drawer__warnings center{% if settings.cart_drawer_collection != blank %} cart-drawer__warnings--has-collection{% endif %}">
             <div class="cart-drawer__empty-content">
-              <h2 class="cart__empty-text">{{ 'sections.cart.empty' | t }}</h2>
+              <span class="cart__empty-text">{{ 'sections.cart.empty' | t }}</span>
               <button
                 class="drawer__close"
                 type="button"
@@ -62,7 +62,7 @@
         </div>
       {%- endif -%}
       <div class="drawer__header">
-        <h2 class="drawer__heading">{{ 'sections.cart.title' | t }}</h2>
+        <span class="drawer__heading">{{ 'sections.cart.title' | t }}</span>
         <button
           class="drawer__close"
           type="button"
@@ -494,7 +494,7 @@
           </div>
 
           <div class="totals" role="status">
-            <h2 class="totals__total">{{ 'sections.cart.estimated_total' | t }}</h2>
+            <span class="totals__total">{{ 'sections.cart.estimated_total' | t }}</span>
             <p class="totals__total-value">{{ cart.total_price | money_with_currency }}</p>
           </div>
 

diff --git a/snippets/facets.liquid b/snippets/facets.liquid
@@ -49,9 +49,9 @@
             {% endif %}
           >
             {%- if filter_type == 'horizontal' and results.filters != empty -%}
-              <h2 class="facets__heading caption-large text-body" id="verticalTitle" tabindex="-1">
+              <span class="facets__heading caption-large text-body" id="verticalTitle" tabindex="-1">
                 {{ 'products.facets.filter_by_label' | t }}
-              </h2>
+              </span>
             {%- endif -%}
             {% comment %} Pills are right below the title for filter type vertical {% endcomment %}
             {%- if filter_type == 'vertical' -%}
@@ -388,9 +388,9 @@
           {%- if enable_sorting -%}
             <div class="facet-filters sorting caption">
               <div class="facet-filters__field">
-                <h2 class="facet-filters__label caption-large text-body">
+                <span class="facet-filters__label caption-large text-body">
                   <label for="SortBy">{{ 'products.facets.sort_by_label' | t }}</label>
-                </h2>
+                </span>
                 <div class="select">
                   {%- assign sort_by = results.sort_by | default: results.default_sort_by -%}
                   <select
@@ -473,20 +473,20 @@
           <div class="mobile-facets__inner gradient">
             <div class="mobile-facets__header">
               <div class="mobile-facets__header-inner">
-                <h2 class="mobile-facets__heading medium-hide large-up-hide">
+                <span class="mobile-facets__heading medium-hide large-up-hide">
                   {%- if enable_filtering and enable_sorting -%}
                     {{ 'products.facets.filter_and_sort' | t }}
                   {%- elsif enable_filtering -%}
                     {{ 'products.facets.filter_button' | t }}
                   {%- elsif enable_sorting -%}
                     {{ 'products.facets.sort_button' | t }}
                   {%- endif -%}
-                </h2>
-                <h2 class="mobile-facets__heading small-hide">
+                </span>
+                <span class="mobile-facets__heading small-hide">
                   {%- if enable_filtering -%}
                     {{ 'products.facets.filter_button' | t }}
                   {%- endif -%}
-                </h2>
+                </span>
                 <p class="mobile-facets__count">
                   {%- if results.results_count -%}
                     {{ 'templates.search.results_with_count' | t: terms: results.terms, count: results.results_count }}
@@ -824,9 +824,9 @@
       <form id="FacetSortDrawerForm" class="facets__form">
         <div class="facet-filters sorting caption small-hide">
           <div class="facet-filters__field">
-            <h2 class="facet-filters__label caption-large text-body">
+            <span class="facet-filters__label caption-large text-body">
               <label for="SortBy">{{ 'products.facets.sort_by_label' | t }}</label>
-            </h2>
+            </span>
             <div class="select">
               {%- assign sort_by = results.sort_by | default: results.default_sort_by -%}
               <select

diff --git a/snippets/header-drawer.liquid b/snippets/header-drawer.liquid
@@ -172,9 +172,9 @@
                   <localization-form>
                     {%- form 'localization', id: 'HeaderCountryMobileForm', class: 'localization-form' -%}
                       <div>
-                        <h2 class="visually-hidden" id="HeaderCountryMobileLabel">
+                        <span class="visually-hidden" id="HeaderCountryMobileLabel">
                           {{ 'localization.country_label' | t }}
-                        </h2>
+                        </span>
                         {%- render 'country-localization', localPosition: 'HeaderCountryMobile' -%}
                       </div>
                     {%- endform -%}
@@ -185,9 +185,9 @@
                   <localization-form>
                     {%- form 'localization', id: 'HeaderLanguageMobileForm', class: 'localization-form' -%}
                       <div>
-                        <h2 class="visually-hidden" id="HeaderLanguageMobileLabel">
+                        <span class="visually-hidden" id="HeaderLanguageMobileLabel">
                           {{ 'localization.language_label' | t }}
-                        </h2>
+                        </span>
                         {%- render 'language-localization', localPosition: 'HeaderLanguageMobile' -%}
                       </div>
                     {%- endform -%}