Move to using Cargo's [lints]

Cargo.toml

@@ -325,3 +325,16 @@ lto = true
 [profile.bench-memory]
 inherits = "bench"
 debug = true
+
+[workspace.lints.rust]
+# missing_docs = "warn"
+missing_debug_implementations = "deny"
+unexpected_cfgs = { level = "warn", check-cfg = ['cfg(icu4x_run_size_tests)', 'cfg(needs_alloc_error_handler)'] }
+
+[workspace.lints.clippy]
+indexing_slicing = "deny"
+unwrap_used = "deny"
+expect_used = "deny"
+panic = "deny"
+exhaustive_structs = "deny"
+exhaustive_enums = "deny"

clippy.toml

@@ -3,3 +3,10 @@
 # (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
 msrv = "1.81"
+
+allow-panic-in-tests = true
+allow-expect-in-tests = true
+allow-unwrap-in-tests = true
+
+# Not yet available in Clippy
+# allow-indexing-slicing-in-tests = true

components/calendar/Cargo.toml

@@ -77,3 +77,7 @@ name = "iso_date_manipulations"
 
 [[example]]
 name = "iso_datetime_manipulations"
+
+
+[lints]
+workspace = true

components/calendar/benches/date.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 mod fixtures;
 
 use criterion::{

components/calendar/benches/datetime.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 mod fixtures;
 
 use criterion::{

components/calendar/src/lib.rs

@@ -95,19 +95,9 @@
 
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
 #![cfg_attr(not(any(test, feature = "std")), no_std)]
-#![cfg_attr(
-    not(test),
-    deny(
-        clippy::indexing_slicing,
-        clippy::unwrap_used,
-        clippy::expect_used,
-        clippy::panic,
-        clippy::exhaustive_structs,
-        clippy::exhaustive_enums,
-        missing_debug_implementations,
-    )
-)]
-#![warn(missing_docs)]
+
+// TODO: until we can enable allow-indexing-slicing-in-tests
+#![cfg_attr(test, allow(clippy::indexing_slicing))]
 
 extern crate alloc;
 

components/casemap/Cargo.toml

@@ -70,3 +70,7 @@ required-features = ["compiled_data", "datagen"] # datagen bound can be removed
 name = "casemap"
 harness = false
 required-features = ["compiled_data"]
+
+
+[lints]
+workspace = true

components/casemap/src/lib.rs

@@ -29,19 +29,6 @@
 
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
 #![cfg_attr(not(any(test, feature = "std")), no_std)]
-#![cfg_attr(
-    not(test),
-    deny(
-        clippy::indexing_slicing,
-        clippy::unwrap_used,
-        clippy::expect_used,
-        clippy::panic,
-        clippy::exhaustive_structs,
-        clippy::exhaustive_enums,
-        missing_debug_implementations,
-    )
-)]
-#![warn(missing_docs)]
 // We're using Greek identifiers here on purpose. These lints can only be disabled at the crate level
 #![allow(confusable_idents, uncommon_codepoints)]
 

components/collator/Cargo.toml

@@ -56,3 +56,7 @@ compiled_data = ["dep:icu_collator_data", "icu_normalizer/compiled_data"]
 [[bench]]
 name = "bench"
 harness = false
+
+
+[lints]
+workspace = true

components/collator/fuzz/Cargo.toml

@@ -30,3 +30,7 @@ name = "compare_utf16"
 path = "fuzz_targets/compare_utf16.rs"
 test = false
 doc = false
+
+
+[lints]
+workspace = true

components/collator/src/lib.rs

@@ -8,19 +8,6 @@
 
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
 #![cfg_attr(not(any(test, feature = "std")), no_std)]
-#![cfg_attr(
-    not(test),
-    deny(
-        clippy::indexing_slicing,
-        clippy::unwrap_used,
-        clippy::expect_used,
-        clippy::panic,
-        clippy::exhaustive_structs,
-        clippy::exhaustive_enums,
-        missing_debug_implementations,
-    )
-)]
-#![warn(missing_docs)]
 
 //! Comparing strings according to language-dependent conventions.
 //!

components/collator/tests/tests.rs

@@ -2,6 +2,8 @@
 // called LICENSE at the top level of the ICU4X source tree
 // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
 
+#![allow(clippy::unwrap_used, clippy::expect_used, clippy::indexing_slicing)] // https://github.com/rust-lang/rust-clippy/issues/13981
+
 use core::cmp::Ordering;
 
 use atoi::FromRadix16;

components/collections/Cargo.toml

@@ -71,3 +71,7 @@ path = "benches/iai_cpt.rs"
 name = "inv_list"
 harness = false
 path = "benches/inv_list.rs"
+
+
+[lints]
+workspace = true

components/collections/codepointtrie_builder/Cargo.toml

@@ -54,3 +54,4 @@ denylist = ["icu4c"]
 
 [lints.rust]
 unexpected_cfgs = { level = "warn", check-cfg = ['cfg(icu4c_enable_renaming)'] }
+

components/collections/codepointtrie_builder/src/lib.rs

@@ -71,20 +71,6 @@
 //! [`CodePointTrie`]: icu_collections::codepointtrie::CodePointTrie
 //! [`UMutableCPTrie`]: (https://unicode-org.github.io/icu-docs/apidoc/dev/icu4c/umutablecptrie_8h.html#ad8945cf34ca9d40596a66a1395baa19b)
 
-#![cfg_attr(
-    not(test),
-    deny(
-        // The crate is documented to allow panics.
-        // clippy::indexing_slicing,
-        // clippy::unwrap_used,
-        // clippy::expect_used,
-        // clippy::panic,
-        clippy::exhaustive_structs,
-        clippy::exhaustive_enums,
-        missing_debug_implementations,
-    )
-)]
-
 use icu_collections::codepointtrie::TrieType;
 use icu_collections::codepointtrie::TrieValue;
 

components/collections/src/codepointinvlist/mod.rs

@@ -51,8 +51,6 @@
 //!
 //! [`ICU4X`]: ../icu/index.html
 
-#![warn(missing_docs)]
-
 extern crate alloc;
 
 #[macro_use]

components/collections/src/lib.rs

@@ -22,16 +22,12 @@
 
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
 #![cfg_attr(not(any(test, feature = "std")), no_std)]
-#![cfg_attr(
-    not(test),
-    deny(
-        clippy::indexing_slicing,
-        clippy::unwrap_used,
-        clippy::expect_used,
-        clippy::panic
-    )
+// TODO
+#![allow(
+    clippy::exhaustive_structs,
+    clippy::exhaustive_enums,
+    missing_debug_implementations
 )]
-#![warn(missing_docs)]
 
 extern crate alloc;
 

components/datetime/Cargo.toml

@@ -108,9 +108,6 @@ skip_optional_dependencies = true
 # Bench feature gets tested separately and is only relevant for CI
 denylist = ["bench"]
 
-[lints.rust]
-unexpected_cfgs = { level = "warn", check-cfg = ['cfg(icu4x_run_size_tests)'] }
-
 [[bench]]
 name = "datetime"
 harness = false
@@ -140,3 +137,7 @@ required-features = ["experimental"]
 [[example]]
 name = "work_log"
 required-features = ["compiled_data"]
+
+
+[lints]
+workspace = true

components/datetime/src/lib.rs

@@ -71,19 +71,9 @@
 
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
 #![cfg_attr(not(any(test, feature = "std")), no_std)]
-#![cfg_attr(
-    not(test),
-    deny(
-        clippy::indexing_slicing,
-        clippy::unwrap_used,
-        clippy::expect_used,
-        clippy::panic,
-        clippy::exhaustive_structs,
-        clippy::exhaustive_enums,
-        missing_debug_implementations,
-    )
-)]
-#![warn(missing_docs)]
+
+// TODO: until we can enable allow-indexing-slicing-in-tests
+#![cfg_attr(test, allow(clippy::indexing_slicing))]
 
 extern crate alloc;
 

components/decimal/Cargo.toml

@@ -56,13 +56,14 @@ compiled_data = ["dep:icu_decimal_data"]
 # Bench feature gets tested separately and is only relevant for CI
 denylist = ["bench"]
 
-[lints.rust]
-unexpected_cfgs = { level = "warn", check-cfg = ['cfg(icu4x_run_size_tests)'] }
-
 [[bench]]
 name = "fixed_decimal_format"
 harness = false
 
 [[example]]
 name = "code_line_diff"
 required-features = ["serde"]
+
+
+[lints]
+workspace = true

components/decimal/src/lib.rs

@@ -77,19 +77,6 @@
 
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
 #![cfg_attr(not(any(test, feature = "std")), no_std)]
-#![cfg_attr(
-    not(test),
-    deny(
-        clippy::indexing_slicing,
-        clippy::unwrap_used,
-        clippy::expect_used,
-        clippy::panic,
-        clippy::exhaustive_structs,
-        clippy::exhaustive_enums,
-        missing_debug_implementations,
-    )
-)]
-#![warn(missing_docs)]
 
 extern crate alloc;
 

components/experimental/Cargo.toml

@@ -106,3 +106,7 @@ path = "tests/transliterate/lower_ascii.rs"
 [[test]]
 name = "units_test"
 path = "tests/units/units_test.rs"
+
+# No boilerplate, each module has their own
+# [lints]
+# workspace = true

components/experimental/src/compactdecimal/mod.rs

@@ -5,19 +5,6 @@
 //! Compact decimal
 
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
-#![cfg_attr(
-    not(test),
-    deny(
-        clippy::indexing_slicing,
-        clippy::unwrap_used,
-        clippy::expect_used,
-        clippy::panic,
-        clippy::exhaustive_structs,
-        clippy::exhaustive_enums,
-        missing_debug_implementations,
-    )
-)]
-#![warn(missing_docs)]
 
 mod error;
 mod format;

components/experimental/src/displaynames/mod.rs

@@ -7,19 +7,6 @@
 // TODO: expand documentation
 
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
-#![cfg_attr(
-    not(test),
-    deny(
-        clippy::indexing_slicing,
-        clippy::unwrap_used,
-        clippy::expect_used,
-        clippy::panic,
-        clippy::exhaustive_structs,
-        clippy::exhaustive_enums,
-        // missing_debug_implementations // TBD before stabilization
-    )
-)]
-#![warn(missing_docs)]
 
 mod displaynames;
 mod options;

components/experimental/src/duration/mod.rs

@@ -4,8 +4,6 @@
 
 //! Duration formatting
 
-#![warn(missing_docs)]
-
 mod duration;
 mod format;
 mod formatter;

components/experimental/src/relativetime/mod.rs

@@ -4,8 +4,6 @@
 
 //! Relative time formatting
 
-#![warn(missing_docs)]
-
 mod format;
 pub mod options;
 pub mod provider;

components/experimental/src/transliterate/mod.rs

@@ -7,19 +7,6 @@
 //! See [`Transliterator`].
 
 // https://github.com/unicode-org/icu4x/blob/main/documents/process/boilerplate.md#library-annotations
-#![cfg_attr(
-    not(test),
-    deny(
-        clippy::indexing_slicing,
-        clippy::unwrap_used,
-        clippy::expect_used,
-        clippy::panic,
-        clippy::exhaustive_structs,
-        clippy::exhaustive_enums,
-        missing_debug_implementations,
-    )
-)]
-#![warn(missing_docs)]
 
 pub mod provider;