Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFI APIs: some gardening, GeneralCategoryGroup #5952

Merged
merged 7 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

- Components
- `icu_provider`
- `GeneralCategoryGroup::contains` now accepts `self` by value (unicode-org#5952)

## icu4x 2.0-beta1

- Components
Expand Down
2 changes: 1 addition & 1 deletion components/properties/src/props.rs
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ impl GeneralCategoryGroup {
/// assert!(GeneralCategoryGroup::Other.contains(gc.get('\u{E007F}')));
/// assert!(!GeneralCategoryGroup::Separator.contains(gc.get('\u{E007F}')));
/// ```
pub const fn contains(&self, val: GeneralCategory) -> bool {
pub const fn contains(self, val: GeneralCategory) -> bool {
0 != (1 << (val as u32)) & self.0
}

Expand Down
5 changes: 2 additions & 3 deletions ffi/capi/bindings/c/CodePointMapData8.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion ffi/capi/bindings/c/CodePointSetData.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ffi/capi/bindings/c/GeneralCategory.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions ffi/capi/bindings/c/GeneralCategoryGroup.d.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 52 additions & 0 deletions ffi/capi/bindings/c/GeneralCategoryGroup.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions ffi/capi/bindings/c/GeneralCategoryNameToGroupMapper.d.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 37 additions & 0 deletions ffi/capi/bindings/c/GeneralCategoryNameToGroupMapper.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 0 additions & 19 deletions ffi/capi/bindings/c/GeneralCategoryNameToMaskMapper.d.h

This file was deleted.

36 changes: 0 additions & 36 deletions ffi/capi/bindings/c/GeneralCategoryNameToMaskMapper.h

This file was deleted.

5 changes: 2 additions & 3 deletions ffi/capi/bindings/cpp/icu4x/CodePointMapData8.d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 5 additions & 11 deletions ffi/capi/bindings/cpp/icu4x/CodePointMapData8.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion ffi/capi/bindings/cpp/icu4x/CodePointSetData.d.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions ffi/capi/bindings/cpp/icu4x/CodePointSetData.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading