Audit datetime format function #5789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth and
zbraniecki
as code owners
|
The names of the FieldLength enum variants predate my time working on this crate. I assume they were chosen to reflect the primary use case for those widths, even if they mean different things in different contexts |
sffc
reviewed
Nov 7, 2024
sffc
previously approved these changes
Nov 7, 2024
robertbastian
commented
Nov 7, 2024
| option_value.ok_or(GetNameForDayPeriodError::NotLoaded) | ||
| } | ||
|
|
||
| pub(crate) fn get_name_for_cyclic( |
robertbastian
requested review from
sffc
and removed request for
zbraniecki and
Manishearth
Manishearth
previously approved these changes
Nov 7, 2024
sffc
previously approved these changes
Nov 7, 2024
Manishearth
previously approved these changes
Nov 7, 2024
sffc
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found several bugs:
FieldLength::TwoDigittruncates the number, which is incorrect. Only theyyandYYpatterns require truncation. I've moved this code to the year branch, and renamed the variantTwoc..ccande..eerequire locale-sensitive day-of-week-number calculations, so they are now rejected during data loadingFieldLength::{Abbreviated, Wide, Narrow}also apply to numeric fields, where they mean 3, 4, 5. I renamed them and updated documentation.