Special-case Z, Z[Etc/UTC] and Z[Etc/GMT] in IXDTF parser
#5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
zbraniecki and
a team
as code owners
robertbastian
changed the title
undZ, Z[Etc/UTC] and Z[Etc/GMT] in IXDTF parser
sffc
previously approved these changes
Oct 31, 2024
| @@ -262,21 +298,42 @@ impl<'a> Intermediate<'a> { | |||
| self.time.minute, | |||
| self.time.second, | |||
| )?; | |||
There was a problem hiding this comment.
Should we now be checking for is_z and failing with MismatchedTimeZoneFields in location_only?
| if self.is_z { | ||
| if let Some(offset) = self.offset { | ||
| if offset != UtcOffsetRecord::zero() { | ||
| return Err(ParseError::RequiresCalculation); |
There was a problem hiding this comment.
This is rejecting Z[-0800], right? Seems like RequiresCalculation isn't quite the right error case?
There was a problem hiding this comment.
We need to subtract 8h from the timestamp, which is definitely a calculation. The only non-calculation offset is Z[+0000].
Co-authored-by: Shane F. Carr <shane@unicode.org>
Manishearth
approved these changes
Oct 31, 2024
sffc
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the only
Zs that don't require any calculation.