-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove generic metazone values that match location values #5751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code seems fine but I'm not fully clear on the implications of this, defer to @sffc or other tz reviewers
70fff71
to
966f972
Compare
966f972
to
7934e4c
Compare
Wikipedia says both names are valid: https://en.wikipedia.org/wiki/Singapore_Time In general I think it's probably safest to only deduplicate in cases of an exact match, as much as I'd like to be more aggressive, and then discuss this list with CLDR to find more opportunities for deduplication. |
These look pretty silly, raising questions about whether we want a Location format to ever be chosen, and instead push people toward an improved Generic Non-Location that supports Generic Partial Location. |
.filter_map(|(region, value)| { | ||
Some(( | ||
icu::locale::subtags::Region::try_from_str(region).ok()?, | ||
value.as_str(), | ||
)) | ||
}) | ||
// Overwrite with short names, as we want to use those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: Can you cite the algorithm where we want short names? I assume you did it maybe to normalize "Myanmar (Burma)" to "Myanmar" and things like that, but normalizing "United Kingdom" to "UK" might not be desirable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UTS-35 does not specify which names to use. I think UK Time
is better than United Kingdom Time
, because it is shorter.
Well they are |
That's what I'm doing. These are observations that we need to bring to CLDR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make a CLDR issue to discuss with the CLDR Design WG, both the short vs long location names and the other issues you found.
-100KB
Generic non-location format ("Central European Time", "Armenia Time") falls back to location ("Zurich Time", "Armenia Time"), so we can remove duplicates.
There are some entries that I feel should be deduplicated, but aren't (metazone name listed first):
Apia Time
vsSamoa Time
Pyongyang Time
vsNorth Korea Time
Taipei Time
vsTaiwan Time
Petropavlovsk-Kamchatski Time
vsKamchatka Time
standard
, which might confuse linguists:Guam Standard Time
vsGuam Time
Singapore Standard Time
vsSingapore Time
Brunei Darussalam Time
vsBrunei Time
Cocos Islands Time
vsCocos (Keeling) Islands Time
Dumont-d’Urville Time
vsDumont d’Urville Time
East Timor Time
vsTimor-Leste Time
Easter Island Time
vsEaster Time
Fernando de Noronha Time
vsNoronha Time
French Southern & Antarctic Time
vsFrench Southern Territories Time
Hong Kong Time
vsHong Kong SAR China Time
Indian Ocean Time
vsBritish Indian Ocean Territory Time
Lanka Time
vsSri Lanka Time
Macao Time
vsMacao SAR China Time
Myanmar Time
vsMyanmar (Burma) Time
North Mariana Islands Time
vsNorthern Mariana Islands Time
Philippine Time
vsPhilippines Time
Pitcairn Time
vsPitcairn Islands Time
Ponape Time
vsPohnpei Time
South Georgia Time
vsSouth Georgia & South Sandwich Islands Time
Wake Island Time
vsWake Time