Implement Bake for VZV types of different formats
#5719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
Manishearth,
sffc and
a team
as code owners
Manishearth
reviewed
Oct 21, 2024
| @@ -291,6 +291,11 @@ pub mod vecs { | |||
| pub use crate::varzerovec::{VarZeroSlice, VarZeroVec}; | |||
|
|
|||
| pub use crate::varzerovec::{Index16, Index32, Index8, VarZeroVecFormat, VarZeroVecOwned}; | |||
|
|
|||
| pub type VarZeroVec16<'a, T> = VarZeroVec<'a, T, Index16>; | |||
There was a problem hiding this comment.
nit: not sure I like these reexports.
| } else { | ||
| let bytes = databake::Bake::bake(&self.as_bytes(), env); | ||
| // Safe because self.as_bytes is a safe input | ||
| quote! { unsafe { zerovec::VarZeroVec::from_bytes_unchecked(#bytes) } } | ||
| quote! { unsafe { zerovec::vecs::VarZeroVec16::from_bytes_unchecked(#bytes) } } |
There was a problem hiding this comment.
nit: we should just use VZV here, the generic gets defaulted
There was a problem hiding this comment.
thought: we could implement for all formats and then do a typeid type check to emit the compact thing for VZV16
There was a problem hiding this comment.
It doesn't, that's the problem. It gets inferred, so it's very unsafe to not specify it.
There was a problem hiding this comment.
@robertbastian hmm, I guess.
sffc
reviewed
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.