Add Expander argument to LocaleCanonicalizer #5718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
dminor,
zbraniecki and
a team
as code owners
Manishearth
force-pushed
the
canonicalizer-generic
branch
from
0a6edfd to
c340ef6
Compare
| /// Data to support canonicalization. | ||
| aliases: DataPayload<AliasesV2Marker>, | ||
| /// Likely subtags implementation for delegation. | ||
| expander: LocaleExpander, | ||
| expander: Expander, |
There was a problem hiding this comment.
convention is to use single letters for generics, this looks like there's an Expander type. Can you use E?
There was a problem hiding this comment.
I've used Expander elsewhere in this crate already. We've been trying to use slightly more descriptive generics where possible, e.g. CaseMapCloser takes a CM. I couldn't come up with a good two-letter one for Expander.
cc @sffc
robertbastian
approved these changes
Oct 21, 2024
sffc
reviewed
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5297