Restructure icu_calendar public API to put all calendars under cal
#5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
approved these changes
Oct 18, 2024
| pub use crate::any_calendar::AnyCalendar; | ||
|
|
||
| /// Scaffolding types: You shouldn't need to use these, they need to be public for the `Calendar` trait impl to work. | ||
| pub mod scaffold { |
There was a problem hiding this comment.
Question: not sure if this should be icu::calendar::cal::scaffold or icu::calendar::scaffold. I feel like a top-level scaffold module is maybe better?
There was a problem hiding this comment.
Merged to avoid conflicts, I'm ambivalent here. I'd approve a PR moving this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5632