Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Err((self, other)) in FixedDecimal::concatenated_end #5623

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Return Err((self, other)) in FixedDecimal::concatenated_end #5623

merged 1 commit into from
Oct 1, 2024

Conversation

Manishearth
Copy link
Member

Fixes #4857

I think that's the only fn *ed* -> Result that we have.

@Manishearth Manishearth requested review from sffc, younies and a team as code owners September 30, 2024 23:12
@Manishearth Manishearth merged commit 1d17017 into unicode-org:main Oct 1, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbastian robertbastian robertbastian approved these changes

@sffc sffc Awaiting requested review from sffc sffc is a code owner

@younies younies Awaiting requested review from younies younies is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FixedDecimal *ed methods should be infallible
2 participants
@Manishearth @robertbastian