Split PropertyNames
#5575
Merged
Split PropertyNames
#5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
Manishearth,
sffc,
aethanyc,
makotokato and
a team
as code owners
Manishearth
approved these changes
Sep 23, 2024
| icu::properties::PropertyNames::new_short#FnInStruct | ||
| icu::properties::PropertyNamesBorrowed#Struct | ||
| icu::properties::PropertyNamesBorrowed::get#FnInStruct | ||
| icu::properties::PropertyNamesLong#Struct |
There was a problem hiding this comment.
nit: potentially in a followup since you're doing a bunch of different changes here, but can you add all the annotations to keep this clean?
There was a problem hiding this comment.
These are actually missing APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script property uses different data structs for short and long names, unlike other properties. Splitting PropertyNames into PropertyNamesLong and PropertyNamesShort allows this to be modeled with the same API as all other properties.