Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AnyPayloadProvider to FixedProvider, make it generic #5502

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

Manishearth
Copy link
Member

Part 1 of #3947

not yet planning on doing part 2

@Manishearth Manishearth requested review from sffc, robertbastian and a team as code owners September 5, 2024 19:27
robertbastian
robertbastian previously approved these changes Sep 6, 2024
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is a clean rename

@Manishearth
Copy link
Member Author

Assuming this is a clean rename

No, it changes semantics too, see the issue. It makes it generic so that it no longer relies on storing an AnyPayload

@Manishearth Manishearth changed the title Rename AnyPayloadProvider to FixedProvider Rename AnyPayloadProvider to FixedProvider, make it generic Sep 6, 2024
provider/adapters/src/fixed.rs Outdated Show resolved Hide resolved
@Manishearth Manishearth requested a review from sffc September 6, 2024 19:45
@sffc
Copy link
Member

sffc commented Sep 7, 2024

failures:

---- tools/md-tests/src/lib.rs - tutorials::data_provider_md (line 210) stdout ----
error[E0107]: associated function takes 0 generic arguments but 1 generic argument was supplied
  --> tools/md-tests/src/lib.rs:244:20
   |
36 |     FixedProvider::new_default::<DecimalSymbolsV1Marker>()
   |                    ^^^^^^^^^^^-------------------------- help: remove these generics
   |                    |
   |                    expected 0 generic arguments
   |
note: associated function defined here, with 0 generic parameters
  --> /home/runner/work/icu4x/icu4x/provider/adapters/src/fixed.rs:79:12
   |
79 |     pub fn new_default() -> Self
   |            ^^^^^^^^^^^

error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0107`.
Couldn't compile the test.

failures:
    tools/md-tests/src/lib.rs - tutorials::data_provider_md (line 210)

test result: FAILED. 20 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 5.89s

error: doctest failed, to rerun pass `-p md-tests --doc`

@Manishearth Manishearth merged commit b7d567f into unicode-org:main Sep 10, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants