Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things here:
DataIdentifierBorrowed
instead ofDataRequest
; metadata should not be relevant for filteringRequestFilterDataProvider
toFilterDataProvider
DataErrorKind::Filtered
for filtered ids, however this does not work with fallback. They should returnDataErrorKind::IdentiferNotFound
; to a caller (like the fallback adapter) it should be opaque whether the pipeline contains a filter or notfilter_by_langid_allowlist_strict
is marked as "will be replaced with a smarter algorithm for locale filtering". This smarter algorithm now exists, so this should be deleted (fixes Add smarter locale filtering in DataExporter #834)Filterable
blanket trait adds.filterable
to every type in this crate's rustdoc, and to every type in dev docs. I replaced it with a normal constructor.