Move unsafe implementations to be in one place. #5104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younies
changed the title
younies
force-pushed
the
dev-remove-unneeded2
branch
from
966782d to
bcbbf27
Compare
younies
commented
Jun 21, 2024
| /// }; | ||
| /// | ||
| /// assert_writeable_eq!(borrowed_pattern.interpolate([5]), "5 days"); | ||
| /// ``` | ||
| unsafe impl VarULE for Pattern<SinglePlaceholder, str> { |
There was a problem hiding this comment.
@sffc , in my opinion, this should be
unsafe impl<B> VarULE for Pattern<B, B::Store>
There was a problem hiding this comment.
it seems it needs more thinking, lets generalize it in another PR
sffc
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.