Better modularisation in icu_provider
#5088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth,
hsivonen,
zbraniecki,
nordzilla and
a team
as code owners
sffc
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Not convinced this makes things better; I understand the desire to reduce re-exports but then why not make the modules more private? At least the macros are convenient to have on the top level since they are usually called in a chain, whereas the other types can be imported.
ffi/capi/src/provider.rs
Outdated
| #[allow(unused_imports)] // feature-specific | ||
| use icu_provider::MaybeSendSync; | ||
| use icu_provider::any::MaybeSendSync; |
There was a problem hiding this comment.
Issue: This trait isn't really any related and should probably be in a different module
There was a problem hiding this comment.
It's only used for bounds in this module, so the only usages outside this module are AnyPayloadProvider and one tutorial that uses any.
sffc
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR namesspaces all macros in
icu_provider, and exports every type only under a single path (as well as the prelude).