Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping legacy databake interface #5059

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jun 14, 2024

All interesting changes are in the first commit

@robertbastian robertbastian requested review from sffc, Manishearth and a team as code owners June 14, 2024 09:49
sffc
sffc previously approved these changes Jun 14, 2024
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but I thought we preferred #[path] over include!

@robertbastian
Copy link
Member Author

We prefer

#[path = "foo.rs"]
mod foo;

over

mod foo {
  include!("foo.rs");
}

but we don't need the nested mods here.

@robertbastian robertbastian merged commit d1c9d50 into unicode-org:main Jun 14, 2024
28 checks passed
@robertbastian robertbastian deleted the baked branch June 14, 2024 15:20
@robertbastian
Copy link
Member Author

#2856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants