Rename data key to data marker [info] #5003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
reviewed
Jun 4, 2024
robertbastian
requested review from
Manishearth,
nordzilla,
aethanyc,
makotokato,
zbraniecki,
hsivonen,
echeran,
dminor and
a team
as code owners
This was referenced Jun 5, 2024
sffc
reviewed
Jun 5, 2024
components/experimental/tests/transliterate/data/baked/macros.rs
Outdated
Show resolved
Hide resolved
sffc
reviewed
Jun 5, 2024
sffc
reviewed
Jun 5, 2024
provider/core/src/lib.rs
Outdated
Comment on lines
223
to
230
| pub use crate::DataKey; | ||
| pub use crate::DataLocale; | ||
| #[doc(no_inline)] | ||
| pub use crate::DataKeyAttributes; | ||
| pub use crate::DataMarker; | ||
| #[doc(no_inline)] | ||
| pub use crate::DataKeyHash; | ||
| pub use crate::DataMarkerAttributes; | ||
| #[doc(no_inline)] | ||
| pub use crate::DataLocale; | ||
| pub use crate::DataMarkerInfo; | ||
| #[doc(no_inline)] | ||
| pub use crate::DataMarker; | ||
| pub use crate::DataMarkerPathHash; |
There was a problem hiding this comment.
These entries were re-ordered. For my own record:
| Old | New |
|---|---|
| DataKey | DataMarkerInfo |
| DataKeyAttributes | DataMarkerAttributes |
| DataKeyHash | DataMarkerPathHash |
| DataLocale | DataLocale |
| DataMarker | DataMarker |
sffc
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4991