BufferProvider is DynamicDataProvider<BufferMarker>
#4992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested changes
Jun 3, 2024
There was a problem hiding this comment.
There are two directions we can take:
- Remove
DynamicDataProviderand acknowledge that the only use cases are in BufferProvider and DataExporter and make traits for those specific situations - Remove
BufferProviderand leverage the more general solution namedDynamicDataProviderto handle that use case
This PR goes toward option 2 but I'm not convinced. I think I had preferred option 1.
I don't know why so many times we end up on different ends of these arbitrary architecture choices...
|
|
Note that this PR lets us remove quite a few implementations. I'd like to point out |
sffc
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.