-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements related to databake::test_bake!()
#4182
Improvements related to databake::test_bake!()
#4182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is great! Did you check whether any other mentions of https://github.com/rust-lang/rust/issues/98906
in the repo can be reenabled now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also fix the other instances of rust-lang/rust#98906 scattered through the codebase?
… `Bake::bake()` output.
I've enables 2 tests outside of
The other 3 tests ignored use derived |
This is great, thanks! |
This PR improves the usefulness of the
test_bake!
macro by making sure the baked tokenstream matches the literal constructor.test_bake!
I've also tried to modify the output of the
Bake
derive macro sotest_bake!
works everywhere but I couldn't figure out the logic for when commas are omitted or not so that's not part of this PR. Unfortunately this means that derived implementations still cannot always be tested usingtest_bake!
. But with this PR, at least primitives, manual implementations, and combinations thereof will now work.