Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make impl<...> Debug for Yoke<...> implementation sound #3686

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Make impl<...> Debug for Yoke<...> implementation sound #3686

merged 1 commit into from
Jul 14, 2023

Conversation

steffahn
Copy link
Contributor

Fixes #3685

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@steffahn
Copy link
Contributor Author

This is a breaking change, however it’s necessary for soundness. See #3685 for a description of the issue and the nature of this change. The breaking part is that the Y: Debug constraint is replaced by for<'a> <Y as Yokeable<'a>>::Output: Debug.

sffc
sffc reviewed Jul 14, 2023
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is a good change. One request.

utils/yoke/src/yoke.rs Show resolved Hide resolved
Manishearth
Manishearth previously approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!!

utils/yoke/src/yoke.rs Show resolved Hide resolved
@Manishearth
Copy link
Member

ready to merge after CI passes

@steffahn

This comment was marked as resolved.

Sign in to view
@Manishearth Manishearth merged commit e09f58d into unicode-org:main Jul 14, 2023
@steffahn steffahn deleted the make_yoke_debug_sound branch July 14, 2023 20:43
@Manishearth Manishearth mentioned this pull request Sep 21, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsound Debug implementation of Yoke
4 participants
@steffahn @CLAassistant @Manishearth @sffc