Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make baked data constructor on owner normalizer types return the borrowed type #5525

Closed
hsivonen opened this issue Sep 11, 2024 · 0 comments · Fixed by #5526
Closed

Make baked data constructor on owner normalizer types return the borrowed type #5525

hsivonen opened this issue Sep 11, 2024 · 0 comments · Fixed by #5526
Labels
2.0-breaking Changes that are breaking API changes C-collator Component: Collation, normalization

Comments

@hsivonen
Copy link
Member

Per review of #5513, the normalizer types don't follow the pattern that baked data constructors on owned types should return the borrowed type and then the constructor macro in the FFI code should use static_to_owned.
@hsivonen hsivonen added C-collator Component: Collation, normalization 2.0-breaking Changes that are breaking API changes labels Sep 11, 2024
hsivonen added a commit to hsivonen/icu4x that referenced this issue Sep 11, 2024
@hsivonen
Change baked data constructors on owned normalizer types to follow co…
c3ca9eb 
…nventions

Closes unicode-org#5525
@hsivonen hsivonen mentioned this issue Sep 11, 2024
Merged
hsivonen added a commit that referenced this issue Sep 12, 2024
@hsivonen
Change baked data constructors on owned normalizer types to follow co…
63a98e4 
…nventions (#5526)

Closes #5525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0-breaking Changes that are breaking API changes C-collator Component: Collation, normalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change baked data constructors on owned normalizer types to follow conventions hsivonen/icu4x
1 participant
@hsivonen