Apply review feedback

unicode-org · Oct 20, 2021 · a598822 · a598822
1 parent fa17495
commit a598822
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 10 deletions.
diff --git a/components/properties/README.md b/components/properties/README.md
@@ -10,7 +10,7 @@ a [`UnicodeSet`]. See the [`sets`] module for more details.
 
 [`ICU4X`]: ../icu/index.html
 [Unicode Properties]: https://unicode-org.github.io/icu/userguide/strings/properties.html
-[`UnicodeSet`]: ../icu_uniset/struct.UnicodeSet.html
+[`UnicodeSet`]: icu_uniset::UnicodeSet
 [`sets`]: crate::sets
 
 ## More Information

diff --git a/components/properties/src/lib.rs b/components/properties/src/lib.rs
@@ -12,13 +12,12 @@
 //!
 //! [`ICU4X`]: ../icu/index.html
 //! [Unicode Properties]: https://unicode-org.github.io/icu/userguide/strings/properties.html
-//! [`UnicodeSet`]: ../icu_uniset/struct.UnicodeSet.html
+//! [`UnicodeSet`]: icu_uniset::UnicodeSet
 //! [`sets`]: crate::sets
 
 #![no_std]
 
 mod props;
-#[allow(unused)]
 pub mod provider;
 pub mod sets;
 mod ule;

diff --git a/components/properties/src/props.rs b/components/properties/src/props.rs
@@ -231,7 +231,7 @@ impl From<GeneralSubcategory> for GeneralCategory {
 /// a particular subset of scripts will be in more than one Script_Extensions set.
 /// For example, DEVANAGARI DIGIT NINE has Script=Devanagari, but is also in the
 /// Script_Extensions set for Dogra, Kaithi, and Mahajani.
-/// For more information, see UAX #24: http://www.unicode.org/reports/tr24/.
+/// For more information, see UAX #24: <http://www.unicode.org/reports/tr24/>.
 /// See UScriptCode in ICU4C.
 #[derive(Copy, Clone, Debug, Eq, PartialEq)]
 #[repr(transparent)]

diff --git a/components/properties/src/sets.rs b/components/properties/src/sets.rs
@@ -320,7 +320,7 @@ where
 }
 
 /// Characters that can come after the first character in an identifier. If using NFKC to
-/// fold differences between characters, use [`get_xid_continue_property`] instead.  See
+/// fold differences between characters, use [`get_xid_continue`] instead.  See
 /// [`Unicode Standard Annex #31`](https://www.unicode.org/reports/tr31/tr31-35.html) for
 /// more details.
 pub fn get_id_continue<'data, D>(provider: &D) -> UnisetResult<'data>
@@ -340,7 +340,7 @@ where
 }
 
 /// Characters that can begin an identifier. If using NFKC to fold differences between
-/// characters, use [`get_xid_start_property`] instead.  See [`Unicode Standard Annex
+/// characters, use [`get_xid_start`] instead.  See [`Unicode Standard Annex
 /// #31`](https://www.unicode.org/reports/tr31/tr31-35.html) for more details.
 pub fn get_id_start<'data, D>(provider: &D) -> UnisetResult<'data>
 where
@@ -610,8 +610,10 @@ where
 
 /// Return a [`UnicodeSet`] for a particular value of the General_Category Unicode enumerated property
 /// General_Category specifies enumerated Unicode general category types.
-/// See https://www.unicode.org/reports/tr44/ .
-pub fn get_general_category_val_set<'data, D>(
+/// See <https://www.unicode.org/reports/tr44/> .
+///
+/// [`UnicodeSet`]: icu_uniset::UnicodeSet
+pub fn get_for_general_category<'data, D>(
     provider: &'data D,
     enum_val: GeneralCategory,
 ) -> UnisetResult
@@ -663,8 +665,10 @@ where
 }
 
 /// Return a [`UnicodeSet`] for a particular value of the Script Unicode enumerated property
-/// See https://www.unicode.org/reports/tr44/ .
-pub fn get_script_val_set<'data, D>(provider: &'data D, enum_val: Script) -> UnisetResult
+/// See <https://www.unicode.org/reports/tr44/> .
+///
+/// [`UnicodeSet`]: icu_uniset::UnicodeSet
+pub fn get_for_script<'data, D>(provider: &'data D, enum_val: Script) -> UnisetResult
 where
     D: DataProvider<'data, UnicodePropertyV1Marker> + ?Sized,
 {