Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22946 Pin all -latest runners per ICU-TC 2024-10-17 🗡️ #3247

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Oct 18, 2024

Pin ubuntu-latest, windows-latest, and macos-latest to their current values, with a note that those are updated in the BRS (I have added a post-release task to the BRS for that).

It does not seem trivial to have that configuration in a single place (configuration variables would work, but those are not part of the repository itself, so they are not source-controlled and they are only accessible to repository owners; I am also not sure how they would behave with PRs from forks). It might be possible to reduce this to one occurrence per file, but 22 files is enough that I would want to three global substitutes anyway, at which point it does not make a difference that there are 83 of them.

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22946
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@markusicu
Copy link
Member

I reopened @FrankYFTang 's ticket in order to unblock this PR.

@markusicu
Copy link
Member

I am happy to rubber-stamp these changes, but we should also have documentation for the new BRS task.

I suggest adding a section here:

Maybe just before the obsolete "Update the pool bundles".

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/processes/release/tasks/build.md is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tnx!

Copy link
Contributor

@mihnita mihnita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a lot of files!

We should probably look into some cleanup...
(not now, of course)

Thank you for this one,
Mihai

@eggrobin eggrobin merged commit 99ca2ad into unicode-org:main Oct 18, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants