do not use if statment

unicode-org · Sep 22, 2023 · eed52a9 · eed52a9
1 parent 8804d47
commit eed52a9
Showing 1 changed file with 4 additions and 12 deletions.
diff --git a/icu4c/source/i18n/units_converter.cpp b/icu4c/source/i18n/units_converter.cpp
@@ -372,20 +372,12 @@ void U_I18N_API addSingleFactorConstant(StringPiece baseStr, int32_t power, Sign
         factor.constantExponents[CONSTANT_FT2M] += 3 * power * signum;
     } else if (baseStr == "in3_to_m3") {
         factor.constantExponents[CONSTANT_FT2M] += 3 * power * signum;
-        if (signum == Signum::NEGATIVE) {
-            factor.factorNum *= std::pow(12 * 12 * 12, power);
-        } else {
-            factor.factorDen *= std::pow(12 * 12 * 12, power);
-        }
+        factor.factorDen *= std::pow(12 * 12 * 12, power * signum);
     } else if (baseStr == "gal_to_m3") {
         factor.constantExponents[CONSTANT_FT2M] += 3 * power * signum;
-        if (signum == Signum::NEGATIVE) {
-            factor.factorDen *= std::pow(231, power);
-            factor.factorNum *= std::pow(12 * 12 * 12, power);
-        } else {
-            factor.factorNum *= std::pow(231, power);
-            factor.factorDen *= std::pow(12 * 12 * 12, power);
-        }
+        factor.factorNum *= std::pow(231, power * signum);
+        factor.factorDen *= std::pow(12 * 12 * 12, power * signum);
+
     } else if (baseStr == "gal_imp_to_m3") {
         factor.constantExponents[CONSTANT_GAL_IMP2M3] += power * signum;
     } else if (baseStr == "G") {