Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17492 Update spotless to 2.43 and google-java-style 1.22 to support Java 21+ #3757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

echeran
Copy link
Contributor

@echeran echeran commented May 28, 2024

(see: unicode-org/unicodetools#828)

CLDR-17492 - catch-all ticket for v46 dependency updates

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@echeran echeran marked this pull request as ready for review May 28, 2024 19:38
echeran added a commit to echeran/cldr that referenced this pull request May 28, 2024
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran echeran changed the title Update spotless to 2.43 and google-java-style 1.22 to support Java 21+ CLDR-17492 Update spotless to 2.43 and google-java-style 1.22 to support Java 21+ May 28, 2024
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do this now. maybe at release. I'm concerned about disruption to in-flight PRs

@echeran
Copy link
Contributor Author

echeran commented May 28, 2024

That's fine. Feel free to merge whenever you think it will be least disruptive.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-apps/src/main/java/org/unicode/cldr/util/CLDRConfigImpl.java is different
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/api/VoteAPIHelper.java is different
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/CookieSession.java is different
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/DBUtils.java is different
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/STFactory.java is different
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/SurveyMain.java is different
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/UserRegistry.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/json/Ldml2JsonConverter.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckDisplayCollisions.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckExemplars.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/tool/UnLiteracyParser.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/CLDRConfig.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/CLDRLocale.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/CLDRPaths.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/CLDRTransforms.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/CLDRURLS.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/CodePointEscaper.java is no longer changed in the branch
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/Emoji.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/LocaleValidator.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/SupplementalDataInfo.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/VoteResolver.java is different
  • tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAnnotations.java is different
  • tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestDisplayAndInputProcessor.java is different
  • tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestExampleGenerator.java is different
  • tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestPathHeader.java is different
  • tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestUtilities.java is no longer changed in the branch
  • tools/cldr-code/src/test/java/org/unicode/cldr/unittest/UnicodeSetPrettyPrinterTest.java is different
  • tools/pom.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/api/Announcements.java is now changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/SurveyMain.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran
Copy link
Contributor Author

echeran commented Sep 19, 2024

@srl295 When is a good time to merge? To cause the least disruption, I think either: 1) the last commit before cutting a release, or 2) the first commit at the beginning of a new release.

I'll leave it to you. I can help keep this PR up to date until then. If not sometime like the above, then there won't be a better time to wait for in order to merge.

@srl295
Copy link
Member

srl295 commented Sep 19, 2024

Probably right after v46 is cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants