CLDR-7646 TestCache concurrency issues

- concurrencyLevel to 1
unicode-org · Jan 11, 2024 · f6aa620 · f6aa620
1 parent a91f8e8
commit f6aa620
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/tools/cldr-code/src/main/java/org/unicode/cldr/test/TestCache.java b/tools/cldr-code/src/main/java/org/unicode/cldr/test/TestCache.java
@@ -2,7 +2,6 @@
 
 import com.google.common.cache.Cache;
 import com.google.common.cache.CacheBuilder;
-import com.google.common.collect.ImmutableList;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map.Entry;
@@ -62,11 +61,19 @@ public void check(String path, List<CheckStatus> result, String value) {
              */
             result.clear();
             Pair<String, String> key = new Pair<>(path, value);
-            List<CheckStatus> cachedResult = pathCache.computeIfAbsent(key, (Pair<String, String> k) -> {
-                List<CheckStatus> l = new ArrayList<CheckStatus>();
-                cc.check(k.getFirst(), file.getFullXPath(k.getFirst()), k.getSecond(), options, l);
-                return l;
-            });
+            List<CheckStatus> cachedResult =
+                    pathCache.computeIfAbsent(
+                            key,
+                            (Pair<String, String> k) -> {
+                                List<CheckStatus> l = new ArrayList<CheckStatus>();
+                                cc.check(
+                                        k.getFirst(),
+                                        file.getFullXPath(k.getFirst()),
+                                        k.getSecond(),
+                                        options,
+                                        l);
+                                return l;
+                            });
             if (cachedResult != null) {
                 result.addAll(cachedResult);
             }
@@ -91,6 +98,7 @@ public List<CheckStatus> getPossibleProblems() {
     private Cache<CheckCLDR.Options, TestResultBundle> testResultCache =
             CacheBuilder.newBuilder()
                     .maximumSize(CLDRConfig.getInstance().getProperty("CLDR_TESTCACHE_SIZE", 12))
+                    .concurrencyLevel(1)
                     .softValues()
                     .build();