[Feature] mq.query: Add js mediaquery #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Slightly delayed: Awesome, thanks!! Some cosmetic things commented in the code. Something I'm wondering right now is whether we should stop exposing Ping @stigmata86 |
| breakpointCurrent = parseInt(estatico.mq.currentBreakpoint.value, 10); | ||
|
|
||
| if (typeof options !== 'object') { | ||
|
|
There was a problem hiding this comment.
We don't use empty lines at the top or bottom of a block's content.
d-simon
force-pushed
the
feature/mq-query
branch
from
da8369c to
5bb7011
Compare
|
About the current breakpoint: It could still come in handy, when one simply wants to compare the current breakpoint. Although perhaps there is a better way to do this? For example: estatico.mq.query({ current: 'large' }); |
backflip
added a commit
that referenced
this pull request
Nov 12, 2015
[Feature] mq.query: Add js mediaquery
|
We will have to check in some specific use cases, but this is already great for now. Thanks a lot! |
ol-ko
pushed a commit
that referenced
this pull request
Jan 21, 2016
…evelop * commit 'f892eb972e6e2e64b74c366993fe843cdb536099': ESTATICO-178: Use bower to load bind polyfill, optimize js:qunit task to handle array of polyfill globs ESTATICO-178: Update jQuery to 2.1.3 ESTATICO-178: Use native JS functions over some jQuery ones removed occurrences of $.proxy and _.bind in favor of native javascript bind method
orioltf
pushed a commit
that referenced
this pull request
Mar 8, 2017
…-78-apply-generic-styles to develop * commit '028fbd3f9575804e34d46d8448f5dc86c71b6443': CONCOREL-78: Basic styles for tables CONCOREL-78: Update headings styles after design change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for js-based mediaqueries as described in #4 :
I haven't added any tests or jsdoc. Thoughts?