Fix/426 inconsitent reading and writing in statismoio #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As updated in the description, this PR is extended to alos fix #332. |
marcelluethi
approved these changes
Mar 21, 2024
madsendennis
approved these changes
Mar 21, 2024
Andreas-Forster
deleted the
fix/426-inconsitent-reading-and-writing-in-statismoio
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #426 which is nescessary to write and read UnstructuredPointsDomains.
A test is introduced for writing and reading an UnstrucutedPointsDomain. The test fails without adapting the StatismoIO class. The test looks a bit more complicated, as only the private method is tested.
UPDATE:
This PR does also fixes #332.
Tests added which checks that passing None creates empty line or triangle lists.