Fix for normalizeDoubleImage #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andreas-Forster
requested changes
Mar 29, 2018
| val min = image.values.min | ||
| val max = image.values.max | ||
| if(min == max){ //if we would divide with 0 | ||
| image.map(_ => (upper-lower)/2) //return mean of [lower,upper] |
There was a problem hiding this comment.
Here it should be (lower+upper)/2 or lower+(upper-lower)/2. I would calculate the constant one above so that it is even better visible that the map does not depend on the position.
| if (lower < 0.0 || upper > 1.0) | ||
| image | ||
| else | ||
| require(lower < upper) |
There was a problem hiding this comment.
The require can be removed as it does not change the correctness. Hence we could invert an image by: normalizeDoubleImageToRange(image,max,min)
| if(min == max){ //if we would divide with 0 | ||
| image.map(_ => (upper-lower)/2) //return mean of [lower,upper] | ||
| }else { | ||
| def normalizer(x: Double) = lower + (x - min) / (max - min) * (upper - lower) |
There was a problem hiding this comment.
Can you precompute the normalization outside of the function? It might be more efficient except it is optimized by the compiler or the JVM and not much less readable I think.
Fixes according to comments from PR in unibas-gravis/scalismo-faces.
Andreas-Forster
approved these changes
Apr 4, 2018
andreas-schneider
approved these changes
Apr 4, 2018
Sorry I introduced a bug which should now be fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added require for arguments
added mean if image min == image max
please do not look at the few other commits inbetween...