MoMoRenderer: Speed up the cached MoMoRenderer for the same instance. #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently when using the cached version of the MoMoRenderer a mesh is generated from the model every time something in the RenderParameter changes. Including illumination and pose, which do not affect mesh generation.
Affected Usecase
This results in unnecessary computation when rendering the same MoMoInstance under different illuminations or poses.
Solution
Do not cache accoding to the RenderParameter but only according to the MoMoInstance part of the RenderParameter.
Result
Speed up of 4 for rendering the same mesh with different poses and illuminations (512x512) when the proposed changes are applied.