Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLYReader does not account for the newline represented as '\r\n' under Windows #89

Closed
Andreas-Forster opened this issue Feb 16, 2018 · 0 comments · Fixed by #90
Closed
Labels

Comments

@Andreas-Forster
Copy link
Member

Andreas-Forster commented Feb 16, 2018

The PLY reader reads the header and parses it in order to construct an appropriate reader. In a second pass, the header is skipped and the actual data is read. When skipping the header the length is calculated based on the last pass. Here happens the error:

  • CURRENT: All new-line representations are assumed to be represented with a length of 1. This is not true under Windows systems and hence leads to errors when parsing a PLY mesh.

  • SOLUTION: Use the length of System.getProperty("line.separator") instead off assuming a length of 1.

Ghazi-Bouabene pushed a commit that referenced this issue Feb 26, 2018
* fixed bug when skipping the header and counted formerly new lines as one character independent of the OS

* reading a ascii-ply file assumes now only consistent punctuation for floating point numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant