Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ungoogled-chromium 128.0.6613.84 #183

Merged
merged 10 commits into from
Aug 24, 2024

Conversation

Cubik65536
Copy link
Member

@Cubik65536 Cubik65536 commented Aug 24, 2024

Notes:

  • A submodule bump is made.
  • A patch refresh is made.
  • Rust is updated according to Chromium requirement.
  • The patch for addressing Ninja 1.12 Dependency issue is now removed because it is no longer needed.
  • The GitHub Release Note generation script is modified so if there is an announcements.md file, an announcement with the file content will be added to the release.
  • An announcement related to sponsorship for notarizing builds is added. (Signed Builds #179 (comment))

Builds and runs fine locally.

CleanShot 2024-08-23 at 21 53 49


Signed-off-by: Qian Qian "Cubik"‎ cubik65536@cubik65536.top

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
@PF4Public
Copy link
Contributor

@networkException Is it how sponsorship announcement supposed to look like? On one hand it is not in readme, so not immediately visible, on the other hand I have no idea how one could make it otherwise.

announcements.md Outdated Show resolved Hide resolved
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
@networkException
Copy link
Member

@networkException Is it how sponsorship announcement supposed to look like? On one hand it is not in readme, so not immediately visible, on the other hand I have no idea how one could make it otherwise.

Yea this is fine, it can also be in the readme I guess.

In general I think the wording could be more "I, the maintainer, am looking to get update work and the developer account sponsored" instead of "we are looking for sponsorships through this individual's account". I don't think its a shame to bring up donations as a topic for free maintenance work, especially if that has costs attached.

I'd also like to avoid this sounding too much like a project wide thing as there's no legal entity or the likes to accept donations.

@Cubik65536
Copy link
Member Author

Cubik65536 commented Aug 24, 2024

@networkException Is it how sponsorship announcement supposed to look like? On one hand it is not in readme, so not immediately visible, on the other hand I have no idea how one could make it otherwise.

Yea this is fine, it can also be in the readme I guess.

In general I think the wording could be more "I, the maintainer, am looking to get update work and the developer account sponsored" instead of "we are looking for sponsorships through this individual's account". I don't think its a shame to bring up donations as a topic for free maintenance work, especially if that has costs attached.

I'd also like to avoid this sounding too much like a project wide thing as there's no legal entity or the likes to accept donations.

I'm actually not sure what is the best way of writing this, so if things has to be changed I can change it and add this to README :)

@Cubik65536
Copy link
Member Author

Cubik65536 commented Aug 24, 2024

I'm changing the second and third paragraphs to something like:

As all Ungoogled-Chromium maintainers are maintaining the software on a voluntary basis, we unfortunately do not have the funds for the Apple Developer Program membership, which is required for notarization.

As of now, I, @Cubik65536, the maintainer of Ungoogled-Chromium macOS, am seeking sponsors to help me cover the cost of the Apple Developer Program fee. If you're interested into getting the "official" Ungoogled-Chromium macOS build notarized, please consider sponsoring me through GitHub Sponsors or Buy me a Coffee.

Would this be better? /cc @networkException

@networkException
Copy link
Member

Yep thats good

Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
Signed-off-by: Qian Qian "Cubik"‎ <cubik65536@cubik65536.top>
@Cubik65536
Copy link
Member Author

Sorry, just a small fix.

@Cubik65536 Cubik65536 merged commit 6a139c5 into ungoogled-software:master Aug 24, 2024
@Cubik65536 Cubik65536 deleted the 128.0.6613.84 branch August 24, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants