Some new additions, some leaner implementations and one breaking change(!)

[chran554]

Breaking change(!) cross function vec2 (float32 float64) now return a scalar value, not a new vector.
Cross-product in 2D is not well-defined but it is changed to the 2D version stated at https://mathworld.wolfram.com/CrossProduct.html .

Add Sinus and Cosine for angle between vectors (vec2 vec3 float64 float32)
Changed implementation for Angle (vec2 vec3 float32 float64) to utilize Cosine implementation (with math.Acos).
Changed implementation for left and right winding (vec2 float32 float64)

Duplicated test file for quaternion (float32 float64)

[ungerik]

Thanks, a little bit more to review :-)

[chran554]

Do you have any thoughts or considerations?
Can I be of assistance?

[ungerik]

Oh sorry, forgot to review… Christian Andersson ***@***.***> schrieb am Mi. 27. Apr. 2022 um 17:55:

Do you have any thoughts or considerations? Can I be of assistance? — Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEWX45CII46OKRJ5UAAPP3VHFPPLANCNFSM5SQUFXUQ> . You are receiving this because you commented.Message ID: ***@***.***>

-- ***@***.*** +43 650 58 33055 Skype: ungerik

[chran554]

ping... :-P

[ungerik]

TestQuaternionRotateVec3 is failing

[chran554]

TestQuaternionRotateVec3 is failing

Yes, indeed it does. I do not remember them failing when I ran the tests previously. I found out that IntelliJ Idea run the tests with success if you run them in debug mode (but fail in normal run mode). (!?)
However, they also fail when running at the command line.

The tests fail because there is a slight difference in the last decimal between the "expected" and "actual" rotated result vector.
I can not trace the error to any of my current (or previous) changes, the rotation that fail only use pretty basic functions.

The same error occur in the master branch.
Try to add this testlogging to the master branch and run the Quaternion test file (float32 version).
Add_test_fail_logging.patch

go test ./...

--- FAIL: TestQuaternionRotateVec3 (0.00s)
    quaternion_test.go:57: test case [-90 0 0] rotates [1 3 -2] failed - rotation: [1 -1.9999999999999996 -3.0000000000000004], [1 -1.9999999999999993 -3.0000000000000004]
    quaternion_test.go:57: test case [28 1043 -38] rotates [1 3 -2] failed - rotation: [2.673166962482776 2.4826629020490287 0.8310013871709876], [2.673166962482776 2.4826629020490283 0.8310013871709876]
    quaternion_test.go:57: test case [90 20 21] rotates [-6 2 9] failed - rotation: [-6.033990983812915 -9.000000000000002 1.8949809516890814], [-6.033990983812915 -9.000000000000002 1.8949809516890816]

[chran554]

Added a fix for the tests. See the diff in commit above if it is appropriate.
fix quaternion tests. They were failing due to precision errors in float values

[ungerik]

Thanks!