Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build conflict, endless import of resources. #266

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

ShutovKS
Copy link
Contributor

Fixed build conflict, endless import of resources. Delay the reset operation to ensure Unity is no longer in the build process. For Unity 6

Delay the reset operation to ensure Unity is no longer in the build process. For Unity 6
@amakropoulos
Copy link
Collaborator

Hi, that's awesome, thanks a lot!
Could you try this with Unity 2022 as well and remove the conditional if if it's not needed?

@ShutovKS
Copy link
Contributor Author

I tested on Unity 2022.3 and was able to build successfully

@amakropoulos amakropoulos changed the base branch from main to release/v2.3.0 October 25, 2024 06:56
@amakropoulos
Copy link
Collaborator

Thank you! Could you rebase it on release/v2.3.0 (git rebase release/v2.3.0)?
Otherwise I'll merge it on a temp branch and do it myself.

@ShutovKS
Copy link
Contributor Author

I think it’s better for you to do this so that I don’t break anything

@amakropoulos
Copy link
Collaborator

Sure, thanks for the help! I'll merge it in the upcoming release.

@amakropoulos amakropoulos deleted the branch undreamai:release/v2.3.0 November 4, 2024 13:25
@amakropoulos amakropoulos reopened this Nov 4, 2024
@amakropoulos amakropoulos merged commit 5dcfc2c into undreamai:release/v2.3.0 Nov 4, 2024
@ShutovKS ShutovKS deleted the fix/reset_operation branch November 4, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants