Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VulnerabilityReport v1alpha2 with grouped packages #277

Merged
merged 19 commits into from
Jun 3, 2024
Merged

VulnerabilityReport v1alpha2 with grouped packages #277

merged 19 commits into from
Jun 3, 2024

Conversation

matheusfm
Copy link
Contributor

@matheusfm matheusfm commented Apr 24, 2024 •
edited
Loading

Description

This pull request

  • adds the v1alpha2 version of VulnerabilityReport (storage version), which has a list of packages in each vulnerability
  • updates Worker container for creating v1alpha2 VulnerabilityReports
  • deprecates the v1alpha1 version of VulnerabilityReport
  • updates the SaaS hooks for sending v1alpha2 VulnerabilityReports (API not implemented yet)
  • sets up a webhook for converting VulnerabilityReport versions
  • adds support for injecting caBundle in CRDs on operator initialization

Linked Issues

UD-1378

How has this been tested?

  • Running unit tests make test
  • Installing Zora with vulnerability scan enabled
  • Upgrading a Zora installation from 0.8.4 to 0.8.5-rc3

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@matheusfm matheusfm added the enhancement New feature or request label Apr 24, 2024
@matheusfm matheusfm self-assigned this Apr 24, 2024
@matheusfm matheusfm mentioned this pull request May 7, 2024
Merged
3 tasks
matheusfm added 2 commits May 8, 2024 10:25
@matheusfm
Setup VulnerabilityReport webhook conversion (#283)
5ad148c 
* implement conversion.Hub in VulnerabilityReport v1alpha1

* move summarize function to v1alpha2 VulnerabilityReport

* implement conversion.Convertible in VulnerabilityReport v1alpha2

* set imagePullPolicy to IfNotPresent in config/manager/manager.yaml

* split install and install-crds targets in Makefile

* logging vulnerability reports conversions

* remove x-kubernetes-preserve-unknown-fields from v1alpha2 vulnerability report

* setup webhook with cert-manager

* setting TLSOpts in webhook server

* generating CRDs with kustomize for applying webhook patch

* installing yq in local binaries directory

* fix CRD generation

* updating CRD annotations

* annotate CRD for injecting conversion

* inject webhook conversion in annotated CRDs

* add flag for enabling/disabling conversion

* update helm chart for generating and mounting certificates if webhook is enabled

* set annotation with jq instead of kustomize

* remove unnecessary base64 encoding

* bump chart version to 0.8.5-rc3

* move NAMESPACE var in Makefile

* delete unused cert-manager files in config/ directory
@matheusfm
Merge branch 'main' into UD-1378-vulnreport-v1alpha2
95cc408
@matheusfm matheusfm requested a review from knrc May 8, 2024 13:32
@matheusfm matheusfm marked this pull request as ready for review May 31, 2024 14:38
knrc
knrc approved these changes May 31, 2024
View reviewed changes
internal/saas/client.go Outdated Show resolved Hide resolved
@matheusfm matheusfm merged commit e7e761c into main Jun 3, 2024
4 checks passed
@matheusfm matheusfm deleted the UD-1378-vulnreport-v1alpha2 branch June 3, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knrc knrc knrc approved these changes

Assignees

@matheusfm matheusfm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheusfm @knrc