Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose plugins env and envFrom as helm chart parameters #245

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Conversation

matheusfm
Copy link
Contributor

Description

Expose plugins env and envFrom as helm chart parameters.

It may be necessary to set environment variables like AWS_REGION in trivy container.

How has this been tested?

By running helm template zora charts/zora/ --set clusterName=mycluster with and without scan.plugins.trivy.env parameter set.

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@matheusfm matheusfm added the enhancement New feature or request label Feb 16, 2024
@matheusfm matheusfm requested a review from knrc February 16, 2024 21:41
@matheusfm matheusfm self-assigned this Feb 16, 2024
@matheusfm matheusfm requested a review from lucasjct February 19, 2024 16:49
Copy link
Contributor

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matheusfm, LGTM

@matheusfm matheusfm merged commit 0989b64 into main Feb 19, 2024
4 checks passed
@matheusfm matheusfm deleted the UD-1209 branch February 19, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants