Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UD-1129: Update reconciliation of misconfigurations and vulnerabiliti… #234

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

knrc
Copy link
Contributor

@knrc knrc commented Jan 19, 2024

…es to check for deltas before sending to SaaS

Description

This PR forces the reconciliation process to check whether the same information has previously been sent to the SaaS, greatly reducing the impact on the service.

Linked Issues

How has this been tested?

  • Scanning was set up on a cluster, with trivy, marvin and popeye scheduled.
  • Monitor SaaS service for PUT calls to the vulnerabilityreports and scan endpoints
  • Monitor logs in zora for Skipping misconfigurations and Skipping vulnerabilities messages
  • Check clusterscan resources to ensure their status section contains processedMisconfigurations and/or processedVulnerabilities

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

…es to check for deltas before sending to SaaS

Signed-off-by: Kevin Conner <kev.conner@getupcloud.com>
@knrc knrc added the bug 🐛 Something isn't working label Jan 19, 2024
@knrc knrc requested a review from lucasjct January 19, 2024 15:47
Copy link
Contributor

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knrc, LGTM.

@knrc knrc merged commit 8d2aa2e into undistro:main Jan 19, 2024
2 checks passed
@knrc
Copy link
Contributor Author

knrc commented Jan 23, 2024

To query the clusterscan resources you can run the following commands

kubectl get clusterscan -o jsonpath='{.items[*].status.processedMisconfigurations}'
and
kubectl get clusterscan -o jsonpath='{.items[*].status.processedVulnerabilities}'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants