Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More comments would be great #138

Closed
karam72 opened this issue Apr 6, 2022 · 1 comment
Closed

More comments would be great #138

karam72 opened this issue Apr 6, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@karam72
Copy link

karam72 commented Apr 6, 2022

First of all tank you for this great application :)

Problem description

I was searching to disable microphone driver from command line for my work laptop. Because I think IT is listening to us at home. I found a script on your project: "Deny app access to microphone". But I don't know anything about it. I research a little bit. I found this: https://docs.microsoft.com/en-us/windows/client-management/mdm/policy-csp-privacy#privacy-letappsaccessmicrophone-forcedenytheseapps

As I understand, the script disables the microphone for Windows Store apps and some desktop apps.

Proposed solution

This is not a problem but I just want to ask if you can add more comments on the scripts, so we can understand better what is going on behind.

You can directly close the issue. I just want to tell you those.

Thank you again this great effort ❤️
@karam72 karam72 added the enhancement New feature or request label Apr 6, 2022
@undergroundwires undergroundwires added the documentation Improvements or additions to documentation label Dec 16, 2023
undergroundwires added a commit that referenced this issue May 21, 2024
@undergroundwires
win: improve disabling app access #138, #121, #339
413e855 
This commit improves disabling app access by correcting minor issues,
adding missing access control configurations and adding more
documentation (#138).

- Introduce shared functions to modify app access for maintainability
  and simplicity.
- Improve comments in generated code
- Fix revert codes showing errors by using `2>nul` in `reg delete`
  commands.
- Fix disabling app access to trusted devices disables access to account
  information, name and picture on older versions of Windows.
- Move disabling app access to location in the same category of others.
- Add missing privacy settings and configurations.
- Add more documentation to scripts
- Rename script names for consistency and clarity.
- Move disabling access to SMS/MMS to phone access disablement category.
- Adjust recommendation levels (discourage more, as #121 suggests):
  - Discourage disabling app access to notifications on 'Standard' to
    address #339 where user reports lack of notifications as bug.
undergroundwires added a commit that referenced this issue May 21, 2024
@undergroundwires
win: improve app access disabling and docs #138
048cc4a 
This commit improves disabling app access by correcting minor issues,
adding missing access control configurations and adding more
documentation (#138) to increase maintainability and user understanding
of privacy settings.

- Introduce shared functions to streamline modifications of app access,
  improving maintainability and simplifying the codebase.
- Move disabling app access to first position in the category.
- Improve code comments for better clarity on generated outputs.
- Resolve error display in revert codes due to incorrect use of `reg
  delete` commands.
- Fix disabling app access to trusted devices disables access to account
  information, name and picture on older versions of Windows.
- Add missing privacy settings and configurations.
- Add more documentation to scripts
- Rename script names for consistency and clarity.
- Move disabling access to SMS/MMS to phone access disablement category.
- Set empty `REG_MULTI_SZ` values to null for GPO access settings to
  maintain registry integrity.
undergroundwires added a commit that referenced this issue May 21, 2024
@undergroundwires
win: improve app access disabling and docs #138
ff3d5c4 
This commit improves disabling app access by correcting minor issues,
adding missing access control configurations and adding more
documentation to increase maintainability and user understanding of
privacy settings, resolving #138.

- Introduce shared functions to streamline modifications of app access,
  improving maintainability and simplifying the codebase.
- Move disabling app access to first position in the category.
- Improve code comments for better clarity on generated outputs.
- Resolve error display in revert codes due to incorrect use of `reg
  delete` commands.
- Fix disabling app access to trusted devices disables access to account
  information, name and picture on older versions of Windows.
- Add missing privacy settings and configurations.
- Add more documentation to scripts
- Rename script names for consistency and clarity.
- Move disabling access to SMS/MMS to phone access disablement category.
- Set empty `REG_MULTI_SZ` values to null for GPO access settings to
  maintain registry integrity.
@undergroundwires
Copy link
Owner

0.13.4 is just released 🎉 and it adds comments for the category and every scripts, including information from your reference.

Thank you for the suggestion @karam72, feel free to give feedback if you're around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@undergroundwires @karam72