add types for suffixed properties, paddingX, etc #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds types for more of the node properties. I think I have them all now.
Background: traits and properties
Mathbox nodes get their properties from "traits". For example,
<grid />
has the following 16 traits:Each trait defines a bunch of properties. For example, the
axis
trait defines two properties:Aliasing
When
Grid
includes"axis:x"
andaxis:y"
as traits, the axis properties get included twice with suffixes X and Y:Previous work
When I originally added Typescript definitions for mathbox (0665621) I did not understand how the above suffix aliasing worked, so I just skipped those properties. Consequently,
<grid>
and a bunch of other node types were missing a bunch of properties. This PR adds them in.