Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new types for latch, reveal, etc #34

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Conversation

ChristopherChudzicki
Copy link
Collaborator

This is a followup to #32, adding typescript definitions for those changes

This is a followup to #32, adding typescript definitions for those changes
@ChristopherChudzicki
Copy link
Collaborator Author

@sritchie I forgot i did not merge this. Anyway... feel free to review/merge, otherwise I will this weekend.

I'm also happy to put together a new release, or you can.

@sritchie
Copy link
Collaborator

Looks good to me.

Question: should we make these two files our first typescript files, and put the types directly in with the new code?

1 similar comment
@sritchie
Copy link
Collaborator

Looks good to me.

Question: should we make these two files our first typescript files, and put the types directly in with the new code?

@ChristopherChudzicki
Copy link
Collaborator Author

Question: should we make these two files our first typescript files, and put the types directly in with the new code?

"These two" being latch.js and reveal.js? I don't think so... If we did, we'd get a lot of anys from the dependencies. I think if we want to convert stuff to ts, the place to start is Model. But, that's just my 2c

@ChristopherChudzicki ChristopherChudzicki merged commit 093b835 into master Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants