#41 add TODOs for possibly using commands here

uncch-rdmc · Sep 30, 2021 · 6a07e16 · 6a07e16
1 parent 2e0ba37
commit 6a07e16
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/main/java/edu/harvard/iq/dataverse/HarvestingSetsPage.java b/src/main/java/edu/harvard/iq/dataverse/HarvestingSetsPage.java
@@ -249,7 +249,7 @@ public void createSet(ActionEvent ae) {
         newOaiSet.setDefinition(getNewSetQuery());
 
         boolean success = false;
-
+        //TODO: Consider putting this in a command that could be used by api as well
         try {
             oaiSetService.save(newOaiSet);
             configuredHarvestingSets = oaiSetService.findAll();  
@@ -292,7 +292,7 @@ public void saveSet(ActionEvent ae) {
 
         // will try to save it now:
         boolean success = false; 
-
+        //TODO: Consider putting this in a command that could be used by api as well
         try {
             oaiSetService.save(oaiSet);
             configuredHarvestingSets = oaiSetService.findAll(); 
@@ -318,6 +318,7 @@ public void saveSet(ActionEvent ae) {
     }
 
     public void deleteSet() {
+        //TODO: Consider putting this in a command that could be used by api as well
         if (selectedSet != null) {
             logger.info("proceeding to delete harvesting set "+ selectedSet.getSpec());
             try {

diff --git a/src/main/java/edu/harvard/iq/dataverse/api/HarvestingServer.java b/src/main/java/edu/harvard/iq/dataverse/api/HarvestingServer.java
@@ -46,7 +46,9 @@ public class HarvestingServer extends AbstractApiBean {
     private static final Logger logger = Logger.getLogger(HarvestingServer.class.getName()); 
 
     // TODO: this should be available to admin only.
-
+    // TODO: if we decide to update the Harvesting Sets Page to use commands for 
+    // Create, Modify, and Delete we should also add them here.
+
     @GET
     @Path("/")
     public Response oaiSets(@QueryParam("key") String apiKey) throws IOException {