Do not use secrets in test run #2201
Open
+4
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows them to be used by PRs from forks.
benjamineskola
force-pushed
the
fix-fork-ci
branch
from
fb7a7e3 to
3a9a502
Compare
pixeltrix
reviewed
Mar 12, 2025
| @@ -2,7 +2,8 @@ DOMAIN="example.com" | |||
| STAGING_API_URL="bops-staging.services" | |||
| STAGING_API_BEARER="fjisdfjsdiofjdsoi" | |||
| OS_VECTOR_TILES_API_KEY="testtest" | |||
| NOTIFY_LETTER_API_KEY='testtest' | |||
| NOTIFY_API_KEY="test_key_for_ci-d64cc892-8848-4663-9544-487551484e9b-d7bc72d1-8e1f-4d5a-a703-de5beecaf4a8" | |||
| NOTIFY_LETTER_API_KEY="test_key_for_ci-d64cc892-8848-4663-9544-487551484e9b-d7bc72d1-8e1f-4d5a-a703-de5beecaf4a8" | |||
There was a problem hiding this comment.
Yes. (Have assumed that because it's specifically for testing and therefore doesn't have permission to do anything, it's less of a risk. Can revert and revoke if that's not the case.)
Problem is that we can't keep it in GH Secrets (if we want to allow PRs from forks) and we can't use a fake key because some of the code is actually instantiating Notify, which throws an error if just given a non-uuid like testtest.
We'd have to track down all of those places and mock Notify (which arguably we should have been doing all along.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows them to be used by PRs from forks.